Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant definition of location-uuid #2058

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

RS-Credentive
Copy link
Contributor

Committer Notes

This PR rationalizes the metadata schema by removing a redundant, unused global flag definition for "location-uuid"

@RS-Credentive RS-Credentive requested a review from a team as a code owner October 31, 2024 10:28
@RS-Credentive
Copy link
Contributor Author

fixes #2056

@aj-stein-gsa
Copy link
Contributor

aj-stein-gsa commented Nov 13, 2024

@RS-Credentive, would you support the inclusion of this PR into a proposed patch release (1.1.3) as this change is not backwards breaking and could resolve issues you have re #2056 in an official release? To that end, could you update this PR to target the change onto the main branch, not develop?

Copy link
Contributor

@iMichaela iMichaela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you for fixing the duplication.

@iMichaela iMichaela merged commit de7b66f into usnistgov:develop Nov 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants