Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codegen #2037

Merged
merged 6 commits into from
Nov 14, 2024
Merged

Codegen #2037

merged 6 commits into from
Nov 14, 2024

Conversation

RS-Credentive
Copy link
Contributor

Committer Notes

This PR updates the names of some of the datatypes with the latest metaschema datatype names. This change is necessary for the metaschema XML files to be properly validated against metaschema.xsd

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

(For reviewers: The wiki has guidance on code review and overall issue review for completeness.)

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.

@RS-Credentive RS-Credentive requested a review from a team as a code owner August 30, 2024 11:25
Copy link
Contributor Author

@RS-Credentive RS-Credentive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Michaela, as requested - my PR is rebased against develop

@iMichaela
Copy link
Contributor

Michaela, as requested - my PR is rebased against develop

Thank you. It looks good now. I'll work on it today (test/approve)

Copy link
Contributor

@iMichaela iMichaela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR updates OSCAL to the Metaschema's latest "date-time-with-timezone" datatype. NIST is ready to merge it into develop and include it in the new (1.1.3) patch release should it NOT impact negatively FedRAMP or other community adopters.

@iMichaela
Copy link
Contributor

[TIME SENSITIVE]: The community's feedback is highly encouraged.

Copy link
Contributor

@david-waltermire david-waltermire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not break backwards compatibility as these types have long been supported in the XSLT and Java implementations.

Copy link
Contributor

@iMichaela iMichaela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you, @RS-Credentive

@iMichaela iMichaela merged commit 7fce8b1 into usnistgov:develop Nov 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants