-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Codegen #2037
Codegen #2037
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Michaela, as requested - my PR is rebased against develop
Thank you. It looks good now. I'll work on it today (test/approve) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR updates OSCAL to the Metaschema's latest "date-time-with-timezone" datatype. NIST is ready to merge it into develop
and include it in the new (1.1.3) patch release should it NOT impact negatively FedRAMP or other community adopters.
[TIME SENSITIVE]: The community's feedback is highly encouraged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not break backwards compatibility as these types have long been supported in the XSLT and Java implementations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you, @RS-Credentive
Committer Notes
This PR updates the names of some of the datatypes with the latest metaschema datatype names. This change is necessary for the metaschema XML files to be properly validated against metaschema.xsd
All Submissions:
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.
(For reviewers: The wiki has guidance on code review and overall issue review for completeness.)
Changes to Core Features: