Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profiler error handling #1944

Conversation

galtm
Copy link
Contributor

@galtm galtm commented Sep 28, 2023

Another attempt at rebasing the previously reviewed PR #1549. The base is develop and all the files I changed are under src/utils/resolver-pipeline. There are 2 commits:

  • 18d52fa - recreating the work from 1549, off the current state of the develop branch
  • 1b1068f - changing 3 directory paths now that the profile resolver code has changed its directory hierarchy

I ran all the profile resolver XSpec tests in Oxygen and there are no failures.

@aj-stein-nist : Is this pull request a reasonable replacement for #1549, or does #1943 have some advantage?

Committer Notes

{Please provide a brief description of what this PR accomplishes. Be sure to reference any issues addressed. If the PR is a work-in-progress submitted for early review, please include [WIP] at the beginning of the title or mark the PR as DRAFT.}

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

(For reviewers: The wiki has guidance on code review and overall issue review for completeness.)

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.

The profile resolver code is less deep than before,
so a relative path from there to the specification
uses one less `../` piece.
@galtm galtm requested a review from wendellpiez as a code owner September 28, 2023 19:49
@galtm galtm mentioned this pull request Sep 28, 2023
7 tasks
@aj-stein-nist aj-stein-nist mentioned this pull request Sep 28, 2023
9 tasks
@aj-stein-nist aj-stein-nist requested review from a team and removed request for wendellpiez September 28, 2023 20:02
Copy link
Contributor

@aj-stein-nist aj-stein-nist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @galtm, I tested locally and it looks good to me.

@aj-stein-nist aj-stein-nist changed the base branch from develop to feature-profile-error-handling September 29, 2023 05:08
@aj-stein-nist aj-stein-nist merged commit d7b6797 into usnistgov:feature-profile-error-handling Sep 29, 2023
@galtm galtm deleted the profiler-error-handling2 branch November 9, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants