-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove with-parent-controls from implementation #1843
Remove with-parent-controls from implementation #1843
Conversation
cfb80d7
to
a5e2fc1
Compare
fb85a27
to
6661368
Compare
0825b9f
to
651deef
Compare
If we can confirm that the flag By 'the model' here we mean both the profile metaschema and the processing spec for profile resolution. The feature should be either supported or missing in both places. If the model permits I just checked and the flag is not defined in https://github.com/usnistgov/OSCAL/blob/develop/src/metaschema/oscal_profile_metaschema.xml so this PR should be fine. |
841544f
to
e1b2b88
Compare
Performed a rebase to address merge conflicts. Just needs a review. |
5f46502
to
72111cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM!
Committer Notes
Remove with-parent-controls from implementation XSLT profile resolver used by oscal-content and current OSCAL release builds and associated tests. Closes #1816.
All Submissions:
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.
(For reviewers: The wiki has guidance on code review and overall issue review for completeness.)
Changes to Core Features:
Have you included examples of how to use your new feature(s)?Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.