Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conan support for userver with ci #131

Closed
wants to merge 1 commit into from
Closed

Conan support for userver with ci #131

wants to merge 1 commit into from

Conversation

xakod
Copy link
Contributor

@xakod xakod commented Oct 2, 2022

Introduce conan package as #119
Diffs from another pr:

  • Do not change anything in source
  • Instead of directly changes in source pr introduces another way: patch sources (it's how conan-center-index packaging works). Patch contains only changing packages names and prefer conan packages over source tree thirdparty packages.
  • Gihub actions

Why patch? As previosly was said there is no current plans to change package naming so I decided do not modify source tree and proposed patch for conan.

Features

Core library building

Current problems

Userver conan package as one monolithic package (userver for cmake for example) instead of

Finally, big thanx to @JorgenPo

@apolukhin
Copy link
Member

Looks very good! Many thanks!

We'll merge it soon, we have to deal with some internal testing issues first

@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2022
@xakod xakod deleted the feature/conan branch October 6, 2022 18:27
YaImedgar pushed a commit to chistopat/userver that referenced this pull request Dec 28, 2022
Tests: протестировано CI
Pull Request Resolved: userver-framework#131
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants