Correct welcome message in the italian locale #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the user's name not being displayed in the italian welcome message
Codecov Report
@@ Coverage Diff @@
## master #950 +/- ##
============================================
- Coverage 36.79% 36.76% -0.03%
Complexity 2122 2122
============================================
Files 158 158
Lines 7216 7216
============================================
- Hits 2655 2653 -2
- Misses 4561 4563 +2
Continue to review full report at Codecov.
|
|
Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the welcome message in Italian is using an incorrect variable for the user's name compared to the other locales, which resulted in the name not being displayed. This PR fixes that.