-
-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ufModel architecture update #941
Conversation
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Bad stalebot! Just because I haven't touched this in almost 3 years doesn't mean I never will! ...I'm just very lazy when it comes to manual testing. |
Codecov Report
@@ Coverage Diff @@
## develop #941 +/- ##
==========================================
Coverage 67.76% 67.76%
Complexity 1997 1997
==========================================
Files 169 169
Lines 6995 6995
==========================================
Hits 4740 4740
Misses 2255 2255 Continue to review full report at Codecov.
|
…type documentation
@lcharette This is ready to go. If you are happy with it, it can be merged. |
This was reverted quite a long time ago due to bugs with the plan being to review this again later on. Leaving this as a stale undocumented branch isn't going to lead to this getting done, so I've thrown this draft PR together.
This has been refactored (to reduce dependence on
this
and provide better documentation of types) and lightly tested. Some redundant code paths have also been eliminated.As an added bonus, less dependence on
this
has resulted in a significant size reduction post-compilation.