ufModel architecture update #941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Bad stalebot! Just because I haven't touched this in almost 3 years doesn't mean I never will! ...I'm just very lazy when it comes to manual testing. |
Codecov Report
@@ Coverage Diff @@
## develop #941 +/- ##
==========================================
Coverage 67.76% 67.76%
Complexity 1997 1997
==========================================
Files 169 169
Lines 6995 6995
==========================================
Hits 4740 4740
Misses 2255 2255 Continue to review full report at Codecov.
|
…type documentation
|
@lcharette This is ready to go. If you are happy with it, it can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was reverted quite a long time ago due to bugs with the plan being to review this again later on. Leaving this as a stale undocumented branch isn't going to lead to this getting done, so I've thrown this draft PR together.
This has been refactored (to reduce dependence on
thisand provide better documentation of types) and lightly tested. Some redundant code paths have also been eliminated.As an added bonus, less dependence on
thishas resulted in a significant size reduction post-compilation.