Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove whitespace at top of page templates #1107

Closed
wants to merge 1 commit into from

Conversation

alexweissman
Copy link
Member

Some third-party tools seem to have issues understanding a webpage that contains whitespace before the DOCTYPE declaration.

Some third-party tools seem to have issues understanding a webpage that contains whitespace before the `DOCTYPE` declaration.
@codecov
Copy link

codecov bot commented Sep 10, 2020

Codecov Report

Merging #1107 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1107   +/-   ##
==========================================
  Coverage      68.01%   68.01%           
  Complexity      1960     1960           
==========================================
  Files            168      168           
  Lines           6884     6884           
==========================================
  Hits            4682     4682           
  Misses          2202     2202           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 825ebde...02dae61. Read the comment docs.

@lcharette
Copy link
Member

Want to way for develop, or push to hotfix ?

@alexweissman
Copy link
Member Author

It can wait until 4.5 or the next patch release, whichever comes first.

@lcharette lcharette modified the milestones: 4.5.0, 4.4.4 Nov 11, 2020
@lcharette lcharette changed the base branch from develop to hotfix November 14, 2020 21:50
@lcharette lcharette changed the base branch from hotfix to develop November 14, 2020 21:51
@lcharette
Copy link
Member

lcharette commented Nov 14, 2020

Since the base got messed up, I merged it manually in Hotfix: 3836585

@lcharette lcharette closed this Nov 14, 2020
@lcharette lcharette deleted the alexweissman-patch-1 branch April 22, 2021 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants