-
-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Font Awesome 5 Icon Picker #1019
Merged
lcharette
merged 12 commits into
userfrosting:develop
from
amosfolz:develop-feature-fa5-iconpicker
Aug 10, 2019
Merged
Feature: Font Awesome 5 Icon Picker #1019
lcharette
merged 12 commits into
userfrosting:develop
from
amosfolz:develop-feature-fa5-iconpicker
Aug 10, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validation fails if these are not included.
Codecov Report
@@ Coverage Diff @@
## develop #1019 +/- ##
==========================================
Coverage 66.99% 66.99%
Complexity 1923 1923
==========================================
Files 161 161
Lines 6703 6703
==========================================
Hits 4491 4491
Misses 2212 2212 Continue to review full report at Codecov.
|
lcharette
approved these changes
Aug 10, 2019
The result is amazing. Great new feature, very useful ! Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a drop-down menu to allow admin to select group icon from a list of available icons.
Ref: #713