Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update build/package.json to use new gulp task name #1078

Closed
alexweissman opened this issue Apr 10, 2020 · 2 comments · Fixed by #1083
Closed

Update build/package.json to use new gulp task name #1078

alexweissman opened this issue Apr 10, 2020 · 2 comments · Fixed by #1083
Labels
assets Related to the assets feature confirmed bug Something isn't working
Milestone
4.4.1

Comments

@alexweissman
Copy link
Member

As brought up in chat by @faligor:

Hi everyone!
I think I found a bug with latest release in terms of assets compiling - when I do
php bakery bake
I receive following error regarding gulp bundle task:
Task never defined: bundle
I think it happens because task name was changed in file build/gulpfile.esm.js from bundle to build but it wasn't changed in file build/package.json:
"uf-bundle": "./node_modules/.bin/gulp bundle",
after changing it to build, command bakery build-assets -f goes smoothly without errors. Would be nice to fix it and I'm sorry if it was already mentioned somewhere.
@alexweissman alexweissman added confirmed bug Something isn't working assets Related to the assets feature labels Apr 10, 2020
@lcharette lcharette added this to the 4.4.x milestone Apr 11, 2020
@lcharette
Copy link
Member

Ref. : cc5fd7b#diff-0509e37bb2d073d996ceb93b5078f6e8L9-R9

lcharette added a commit that referenced this issue Apr 11, 2020
@lcharette
Fix #1078
488ce84
@lcharette
Copy link
Member

A Github action should probably be used to test this...

@lcharette lcharette modified the milestones: 4.4.x, 4.4.1 Apr 22, 2020
@lcharette lcharette linked a pull request Apr 23, 2020 that will close this issue
4.4.1 Release #1083
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
assets Related to the assets feature confirmed bug Something isn't working
Projects
None yet
Milestone
4.4.1
Development

Successfully merging a pull request may close this issue.

4.4.1 Release userfrosting/UserFrosting
2 participants
@lcharette @alexweissman