fix(omnio): harden conversation browser sessions - #52
Closed
ppazosp wants to merge 1 commit into
Closed
Conversation
Author
|
Superseded by native GitHub Stack NousResearch#56: #54 → #55 → #53. The top of that stack is byte-for-byte equivalent to this PR, with each concern now independently reviewable and verified at its branch boundary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Browser.closeto provider-owned Chrome processes~inside the Sprite rather than against the gateway hostWhy
The affected traces combined cross-chat browser ownership bugs with Hermes-side cleanup, recovery, raw-CDP, background-job, and sandbox path assumptions. These changes consume Omnia's per-conversation browser contract and remove the remaining paths that could kill another chat's browser or report false environment failures.
Verification
git diff --checkpassedacpcollection dependencies and macOS path/systemd assumptionsBackward compatibility
Backward compatible. New Hermes prefers the additive session-templated CDP contract but falls back to the existing static endpoint with old Omnia; old Hermes continues to work against new Omnia through that legacy endpoint. Existing adapters that do not declare the new push-delivery capability retain their prior behavior, and no persisted-data migration is required.