refactor(omnio): use Omnio paths for worker artifacts - #113
Merged
Merged
Conversation
ppazosp
marked this pull request as ready for review
September 18, 2026 09:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Worker summaries and transcript paths exposed to Toolbox should belong to Omnio regardless of the agent harness. New worker artifacts now use
/tmp/.omnio-session/cache/delegation/through the existing file synchronization mechanism. The harness keeps its own private profile storage; no new Toolbox API or transport is introduced.This follow-up to #112 changes only the worker artifact namespace. General Hermes execution scratch paths and non-Sprites backends retain their current behavior. Existing Toolbox copies are not moved or removed.
Backward compatibility
Backward compatible. New Hermes uses the same authenticated
/filesoperations against existing Toolbox versions, which accept the new path. Old Hermes works with new Toolbox assets, including the retained.hermes-sessiongeneration-transfer exclusion. No Omnia client, database, event, or capability contract changes. Existing copied files keep their original paths for their current lifetime; these caches remain ephemeral across generation transfer. Older transfer helpers may copy the new cache until the companion Omnia PR #4693 is present, without affecting file access. No coordinated rollout is required.Verification
All eight Python CI slices passed at
d0e737e5d4, along with the other code checks: run 35328573361.Canonical
scripts/run_tests.sh, with file retries disabled: 143 passed, 0 failed across delegation artifact delivery, live transcripts, credential mapping, file synchronization, and Sprites environment suites. Ruff andgit diff --checkpass. The artifact suite uses real local HTTP requests and separate harness/Toolbox directories; the summary and log assertions independently require the Omnio path. This namespace-only follow-up has not been rerun against a live Sprite; #112 retains the prior real-Sprite evidence for the unchanged transport.itname)test_delegation_artifact_delivery.py › test_summary_path_can_be_read_completely_from_toolboxtest_delegation_artifact_delivery.py › test_live_log_refreshes_before_each_parent_readtest_delegation_artifact_delivery.py › test_large_artifact_uses_raw_upload_without_truncationtest_delegation_artifact_delivery.py › test_invalid_artifact_destination_is_rejectedtest_delegation_artifact_delivery.py › test_failed_transfer_is_reported_and_retried