Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct separator in migration file name #4327

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

l2dy
Copy link
Contributor

@l2dy l2dy commented Jan 29, 2025

Fixes: e913271 ("refactor: move tags from property to payload (#4229)")

See:

memos/store/migrator.go

Lines 28 to 30 in 75fd422

// MigrateFileNameSplit is the split character between the patch version and the description in the migration file name.
// For example, "1__create_table.sql".
MigrateFileNameSplit = "__"

Fixes: e913271 ("refactor: move tags from property to payload (usememos#4229)")
@l2dy l2dy requested a review from boojack as a code owner January 29, 2025 16:22
@l2dy
Copy link
Contributor Author

l2dy commented Jan 29, 2025

It seems that the file was added in mistake, because the corresponding LATEST.sql file was not updated. Maybe we should just delete the file instead?

Copy link
Collaborator

@johnnyjoygh johnnyjoygh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@johnnyjoygh
Copy link
Collaborator

It seems that the file was added in mistake, because the corresponding LATEST.sql file was not updated. Maybe we should just delete the file instead?

I think it's WAI as we'll update the LATEST.sql in 0.24.0.

@johnnyjoygh johnnyjoygh merged commit 5ec3150 into usememos:main Jan 30, 2025
@l2dy l2dy deleted the 0.24-migration branch January 30, 2025 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants