Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #4144 now when there is no sso then the Disallow password auth is… #4148

Merged
merged 3 commits into from
Nov 29, 2024
Merged

fix #4144 now when there is no sso then the Disallow password auth is… #4148

merged 3 commits into from
Nov 29, 2024

Conversation

X1Vi
Copy link
Contributor

@X1Vi X1Vi commented Nov 25, 2024

… disabled

@X1Vi X1Vi requested a review from boojack as a code owner November 25, 2024 17:00
@X1Vi
Copy link
Contributor Author

X1Vi commented Nov 25, 2024 •
edited
Loading

fix now if SSOs are not there then disallows password auth is disabled #4144

@X1Vi
Copy link
Contributor Author

X1Vi commented Nov 28, 2024

Hi @boojack could you review this PR.

johnnyjoygh
johnnyjoygh approved these changes Nov 29, 2024
View reviewed changes
Copy link
Collaborator

@johnnyjoygh johnnyjoygh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnnyjoygh johnnyjoygh merged commit 009f495 into usememos:main Nov 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RoccoSmit RoccoSmit RoccoSmit left review comments

@johnnyjoygh johnnyjoygh johnnyjoygh approved these changes

@boojack boojack Awaiting requested review from boojack boojack is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@X1Vi @RoccoSmit @johnnyjoygh @pransh62390