Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show less when memo expanded #4143

Merged
merged 2 commits into from
Nov 24, 2024
Merged

Conversation

RoccoSmit
Copy link
Contributor

As per issue #4142. Currently large memos has an option to start compacted and show more, but can then not be set back to a compacted state.

This PR is to add the functionality to set an expanded memo back to a compacted state

Show more state:
show more

Show less state:
show less

@RoccoSmit RoccoSmit changed the title Added show less action and language files Ability to show less when memo expanded Nov 23, 2024
Copy link
Collaborator

@boojack boojack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits

web/src/components/MemoContent/index.tsx Outdated Show resolved Hide resolved
web/src/components/MemoContent/index.tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@johnnyjoygh johnnyjoygh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnnyjoygh johnnyjoygh changed the title Ability to show less when memo expanded feat: show less when memo expanded Nov 24, 2024
@johnnyjoygh johnnyjoygh merged commit 54ee2bf into usememos:main Nov 24, 2024
2 checks passed
@RoccoSmit RoccoSmit deleted the show-less branch November 24, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants