Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: delete memo comments when memo is deleted #3491

Merged
merged 3 commits into from
Jun 3, 2024
Merged

feat: delete memo comments when memo is deleted #3491

merged 3 commits into from
Jun 3, 2024

Conversation

mmacdo54
Copy link
Contributor

…n a memo is deleted

  • Added logic that deletes the memo relation if exists
  • Added logic that recursively calls the DeleteMemo function for all the Memo comments

@mmacdo54 mmacdo54 requested a review from boojack as a code owner May 30, 2024 18:43
@mmacdo54 mmacdo54 mentioned this pull request May 30, 2024
Closed
@mmacdo54 mmacdo54 requested a review from boojack June 3, 2024 11:45
boojack
boojack approved these changes Jun 3, 2024
View reviewed changes
Copy link
Collaborator

@boojack boojack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@boojack boojack changed the title Added logic to delete memo relation and memo comments recursively whe… feat: delete memo comments when memo is deleted Jun 3, 2024
@boojack boojack merged commit 760dee4 into usememos:main Jun 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boojack boojack boojack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmacdo54 @boojack