Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: telegram callback query handler dereferencing nil pointer if memo not found #3003

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

ericd23
Copy link
Contributor

@ericd23 ericd23 commented Feb 26, 2024

If a memos added through telegram is deleted and we try to change the visibility in telegram, server will dereference a nil pointer in the handler when dispatching webhook.

@ericd23 ericd23 requested a review from boojack as a code owner February 26, 2024 10:11
Copy link
Collaborator

@boojack boojack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@boojack boojack merged commit 1ae9bf2 into usememos:main Feb 26, 2024
5 checks passed
@ericd23 ericd23 deleted the fix-tg-memo-not-found branch February 26, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants