Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add mermaid support in codeblock #2971

Merged
merged 12 commits into from
Feb 19, 2024

Conversation

C1C0
Copy link
Contributor

@C1C0 C1C0 commented Feb 17, 2024

Motivation

MermaidJS is a user-friendly diagramming tool. It is known for making diagram creation easier and faster than writing detailed descriptions. By adding MermaidJS to Memos, I aim to enable users to include various types of diagrams, like mind maps, in their notes. This integration is intended to make the sharing of complex ideas more straightforward and visually appealing, helping to communicate information more effectively in memos.

Example:

image

image

@C1C0 C1C0 requested a review from boojack as a code owner February 17, 2024 20:37
web/src/components/MemoContent/CodeBlock.tsx Outdated Show resolved Hide resolved
web/src/components/MemoContent/MermaidBlock.tsx Outdated Show resolved Hide resolved
@MehadND
Copy link
Contributor

MehadND commented Feb 18, 2024

What about the pricing? Free? Kind of confused. Thanks

Copy link
Collaborator

@boojack boojack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, otherwise

web/src/components/MemoContent/MermaidBlock.tsx Outdated Show resolved Hide resolved
web/src/components/MemoContent/CodeBlock.tsx Outdated Show resolved Hide resolved
@boojack boojack merged commit 03d67d5 into usememos:main Feb 19, 2024
5 checks passed
@C1C0 C1C0 deleted the feat/add-mermaid-support-in-codeblock branch February 19, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants