-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: server overrides user's locale/appearance #2771
fix: server overrides user's locale/appearance #2771
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM otherwise
ce5b52a
to
4c70bfa
Compare
Test: user can change user locale in Note: currently when a user doesn't set locale, the default user setting |
So the order here should be |
FYI, fixed in 9ffd827 |
But what if a user specifies a new locale in login/sign up page? It will be overriden when the user is logged in. @boojack I presume that users can configure additional preferences during the login process; otherwise, those buttons would lose their purpose and require users to reconfigure locale/appearance in the settings later. |
Some scenarios to consider:
So considering above scenarios, I considered using |
Close #2767.
Locale usage sequence:
storage locale
>user locale
>server's default locale
. (same for appearance)