Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix store tests on Windows #2769

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

lincolnthalles
Copy link
Contributor

It's just a matter of explicitly closing the database, so that TempDir.removeAll doesn't fail. This doesn't affect other systems.

Screenshot_1 => Screenshot_2

It's just a matter of explicitly closing the database, so that TempDir.removeAll doesn't fail.
Copy link
Collaborator

@boojack boojack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@boojack boojack merged commit 5bcbbd4 into usememos:main Jan 16, 2024
5 checks passed
@lincolnthalles lincolnthalles deleted the chore/fix-go-tests-on-Windows branch May 10, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants