Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: image upload failed with cloudflare R2 #2704

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

xwjdsh
Copy link
Contributor

@xwjdsh xwjdsh commented Jan 4, 2024

Fix #2630


I noticed that aws-go-sdk was upgraded to v1.24.0 again, and saving resources to R2 failed. I tested Cloudflare R2 and it worked fine with the changes.

@xwjdsh xwjdsh requested a review from boojack as a code owner January 4, 2024 10:28
@boojack boojack changed the title Fix image upload failed with cloudflare R2 fix: image upload failed with cloudflare R2 Jan 4, 2024
Copy link
Collaborator

@boojack boojack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution!

@boojack boojack merged commit 6b2eec8 into usememos:main Jan 4, 2024
5 checks passed
@xwjdsh xwjdsh deleted the bugfix/r2-upload branch January 4, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.18.1 Failed to save resource to R2
2 participants