Delete .vscode directory #2693
Merged
Delete .vscode directory #2693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you explain why? |
I was suggesting deleting .vscode directory because if we somebody wants to have custom configs in .vscode, they would be overidding the folder. Secondly, the .vscode property is something which shouldn't be part of source code as it is not source code. |
|
|
|
Sure. I can add that folder as well in the PR
…On Fri, 12 Jan, 2024, 5:05 am boojack, ***@***.***> wrote:
./web/.vscode can also be deleted.
—
Reply to this email directly, view it on GitHub
<#2693 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFJBWLL3553GIDBJYB63VZ3YOBZKTAVCNFSM6AAAAABBJFLXFCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBYGEZTINRVHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
boojack
approved these changes
Jan 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.