Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix misuse of package path instead of filepath.path #2684

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

lincolnthalles
Copy link
Contributor

As stated by https://pkg.go.dev/path, "path" is mainly for URLs, "path.filepath" for file systems

As stated by https://pkg.go.dev/path, "path" is mainly for URLs, "path.filepath" for file systems
Copy link
Collaborator

@boojack boojack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@boojack boojack merged commit 14b34ed into usememos:main Dec 28, 2023
5 checks passed
@lincolnthalles lincolnthalles deleted the use-os-agnostic-filepath branch January 14, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants