fix: database is locked #1992
Merged
fix: database is locked #1992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The option "_journal_mode=WAL" is currently *not* being applied when provided in the DSN. This issue affects only new memos installations, not older ones where the database journal was properly set to WAL mode by the previous sqlite library go-sqlite3. modernc.org/sqlite DSN parsing is different from go-sqlite3. It requires the `_pragma=` prefix and even some options order matter. https://gitlab.com/cznic/sqlite/-/issues/115 Closes usememos#1985
|
Uffizzi Preview |
lincolnthalles
added a commit
to lincolnthalles/memos
that referenced
this pull request
Oct 21, 2023
* fix: database is locked The option "_journal_mode=WAL" is currently *not* being applied when provided in the DSN. This issue affects only new memos installations, not older ones where the database journal was properly set to WAL mode by the previous sqlite library go-sqlite3. modernc.org/sqlite DSN parsing is different from go-sqlite3. It requires the `_pragma=` prefix and even some options order matter. https://gitlab.com/cznic/sqlite/-/issues/115 Closes usememos#1985 * chore: upgraded notes on sqlite DSN
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The option "_journal_mode=WAL" is currently not being applied when provided in the DSN.
This issue affects only new memos installations, not older ones where the database journal was properly set to WAL mode by the previous sqlite library go-sqlite3.
modernc.org/sqlite DSN parsing is different from go-sqlite3. It requires the
_pragma=prefix and even some options order matter.https://gitlab.com/cznic/sqlite/-/issues/115
By the way, as stated at sqlite documentation, it's a good practice to keep "cache=private" and "foreign_keys=0" explicit, even though it's the current default behavior, as sqlite defaults may change at some point.
Closes #1985