Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disallow destructuring 't' from useTranslation #1973

Merged
merged 10 commits into from
Jul 16, 2023
Merged

chore: disallow destructuring 't' from useTranslation #1973

merged 10 commits into from
Jul 16, 2023

Conversation

Ajaykumbhare
Copy link
Contributor

This commit adds a linting rule to disallow the destructuring of the 't' property from the result of the useTranslation function call. The no-restricted-syntax rule in the ESLint configuration has been updated to enforce this restriction. The intention is to promote alternative approaches like using the useTranslate hook for localization.

This commit adds a linting rule to disallow the destructuring of the 't' property from the result of the useTranslation function call. The no-restricted-syntax rule in the ESLint configuration has been updated to enforce this restriction. The intention is to promote alternative approaches like using the useTranslate hook for localization.
@Ajaykumbhare Ajaykumbhare requested a review from boojack as a code owner July 16, 2023 13:12
Copy link
Collaborator

@boojack boojack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@boojack boojack changed the title chore: Disallow destructuring 't' from useTranslation chore: disallow destructuring 't' from useTranslation Jul 16, 2023
@github-actions
Copy link

github-actions bot commented Jul 16, 2023

Uffizzi Preview deployment-31007 was deleted.

@boojack boojack merged commit 4ac63ba into usememos:main Jul 16, 2023
lincolnthalles pushed a commit to lincolnthalles/memos that referenced this pull request Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants