Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: incorrect localization key for sign-up failure message #1953

Merged
merged 1 commit into from
Jul 14, 2023
Merged

fix: incorrect localization key for sign-up failure message #1953

merged 1 commit into from
Jul 14, 2023

Conversation

Ajaykumbhare
Copy link
Contributor

  • Updated the localization key used for the sign-up failure message in the handleSignUpButtonClick function of Auth.tsx.
  • Replaced common.signup-failed with the correct localization key message.signup-failed to ensure proper localization.
  • This fix ensures that the correct localization key is used for the sign-up failure message, providing accurate translations and a better user experience.

@Ajaykumbhare Ajaykumbhare requested a review from boojack as a code owner July 14, 2023 13:27
@github-actions
Copy link

github-actions bot commented Jul 14, 2023 •
edited
Loading

Uffizzi Preview deployment-30928 was deleted.

boojack
boojack approved these changes Jul 14, 2023
View reviewed changes
Copy link
Collaborator

@boojack boojack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution!

@boojack boojack changed the title #1952 Fix incorrect localization key for sign-up failure message fix: incorrect localization key for sign-up failure message Jul 14, 2023
@boojack boojack merged commit 8ca2dac into usememos:main Jul 14, 2023
lincolnthalles pushed a commit to lincolnthalles/memos that referenced this pull request Oct 21, 2023
@Ajaykumbhare @lincolnthalles
fix: incorrect localization key for sign-up failure message (usememos…
520517e 
…#1953)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boojack boojack boojack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ajaykumbhare @boojack