Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: split save resource asset #1939

Merged
merged 4 commits into from
Jul 14, 2023
Merged

chore: split save resource asset #1939

merged 4 commits into from
Jul 14, 2023

Conversation

athurg
Copy link
Contributor

@athurg athurg commented Jul 13, 2023

This PR split the code for resource blob save into a function. After that, all resource upload use this function to save blob, include:

  • Upload from HTTP API POST /resource/blob
  • Upload from HTTP API POST /resource with external URL link.
  • Upload from Telegram message

@athurg athurg requested a review from boojack as a code owner July 13, 2023 04:43
@athurg athurg linked an issue Jul 13, 2023 that may be closed by this pull request
Telegram上传图片bug #1902
Closed
@athurg athurg self-assigned this Jul 13, 2023
@athurg athurg added the backend label Jul 13, 2023
@github-actions
Copy link

github-actions bot commented Jul 13, 2023 •
edited
Loading

Uffizzi Preview deployment-30789 was deleted.

boojack
boojack approved these changes Jul 13, 2023
View reviewed changes
Copy link
Collaborator

@boojack boojack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, otherwise

api/v1/resource.go Outdated Show resolved Hide resolved
api/v1/resource.go Outdated Show resolved Hide resolved
@athurg
Copy link
Contributor Author

athurg commented Jul 14, 2023

Wait a minute, I'll rebase on the latest main branch to fix the conflict.

@athurg athurg force-pushed the chore/split_save_resource_asset branch from c4b1760 to ae28220 Compare July 14, 2023 03:07
@athurg
Copy link
Contributor Author

athurg commented Jul 14, 2023

It's ready now, you can just merge this if there's any other problems.

@boojack boojack merged commit 06dbd87 into main Jul 14, 2023
@athurg athurg deleted the chore/split_save_resource_asset branch July 14, 2023 03:15
lincolnthalles pushed a commit to lincolnthalles/memos that referenced this pull request Oct 21, 2023
@athurg @lincolnthalles
chore: split save resource asset (usememos#1939)
b57c899 
* Move resource blob save into a independent function

* Support save resouce blob from Telegram like HTTP API

* Support save resouce blob download from URL to LocalStorage or S3

* fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boojack boojack boojack approved these changes

Assignees

@athurg athurg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Telegram上传图片bug
2 participants
@athurg @boojack