feat: Add support for purged resource link #1897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Uffizzi Preview |
lincolnthalles
pushed a commit
to lincolnthalles/memos
that referenced
this pull request
Oct 21, 2023
Add support for purged resource link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the resource link has two forms like below:
/o/r/:resourceId/:publicId, which is marked as DEPRECATED./o/r/:resourceId/:publicId/:filenameBoth of them are too redundant. In fact, just a
resourceIdis enough to fetch a resource.So I made this PR to add support for a new link form like
/o/r/:resourceId.For compatible with the old version, the old styles are still be supported, but should migrate the the new one.
And in the next version, I'll change the link in frontend code to this new form.