Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for download resource from link #1800

Merged
merged 5 commits into from
Jun 8, 2023

Conversation

athurg
Copy link
Contributor

@athurg athurg commented Jun 5, 2023

This PR add a new feature to support download a resource from external link, instead of just create a reference link to it.

This feature also close #1722

@athurg athurg added the enhancement New feature or request label Jun 5, 2023
@athurg athurg self-assigned this Jun 5, 2023
server/resource.go Fixed Show fixed Hide fixed
@github-actions
Copy link

github-actions bot commented Jun 5, 2023

Uffizzi Preview deployment-27561 was deleted.

Copy link
Collaborator

@boojack boojack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

server/resource.go Show resolved Hide resolved
@athurg athurg marked this pull request as ready for review June 7, 2023 03:00
server/resource.go Outdated Show resolved Hide resolved
@boojack boojack enabled auto-merge (squash) June 8, 2023 14:34
@boojack boojack merged commit e6c9f2a into usememos:main Jun 8, 2023
@athurg athurg deleted the download_external_resource branch June 8, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants