Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix system memo visibility was replace by user's setting #1707

Merged
merged 1 commit into from
May 22, 2023
Merged

Fix system memo visibility was replace by user's setting #1707

merged 1 commit into from
May 22, 2023

Conversation

athurg
Copy link
Contributor

@athurg athurg commented May 22, 2023 •
edited
Loading

The memos visibility in System Setting must priority than the user'.

For example, while the user

  • Set Disable public memos in Admin-System-Settings to true
  • Set Default memo visibility in Basic-Preferences-Preferences to Public to everyone.

The new memos should use only Private visibility. But it shows Public to everyone on the memos create dialog, and not selectable.

Memos create dialog preferences setting system setting

@athurg athurg requested a review from boojack as a code owner May 22, 2023 03:15
@github-actions
Copy link

github-actions bot commented May 22, 2023 •
edited
Loading

Uffizzi Preview deployment-26068 was deleted.

boojack
boojack approved these changes May 22, 2023
View reviewed changes
Copy link
Collaborator

@boojack boojack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@boojack boojack merged commit 3b1bab6 into usememos:main May 22, 2023
@athurg athurg deleted the fix_memo_editor_visibility branch May 22, 2023 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boojack boojack boojack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@athurg @boojack