Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/sort memos by updated ts #1648

Closed
wants to merge 5 commits into from
Closed

Feat/sort memos by updated ts #1648

wants to merge 5 commits into from

Conversation

titanventura
Copy link
Contributor

Fixes #1261

@titanventura titanventura requested a review from boojack as a code owner May 10, 2023 16:42
@titanventura
Copy link
Contributor Author

Please review @boojack. Thanks !

@boojack boojack requested a review from CorrectRoadH May 10, 2023 17:06
CorrectRoadH
CorrectRoadH approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@CorrectRoadH CorrectRoadH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

web/src/components/Settings/PreferencesSection.tsx Outdated Show resolved Hide resolved
web/src/components/Settings/PreferencesSection.tsx Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented May 11, 2023 •
edited
Loading

Uffizzi Ephemeral Environment deployment-24881

☁️ https://app.uffizzi.com/github.com/usememos/memos/pull/1648

📄 View Application Logs etc.

What is Uffizzi? Learn more!

@titanventura titanventura requested a review from CorrectRoadH May 11, 2023 04:32
CorrectRoadH
CorrectRoadH approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@CorrectRoadH CorrectRoadH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

web/src/locales/en.json Outdated Show resolved Hide resolved
@titanventura titanventura requested a review from CorrectRoadH May 12, 2023 09:36
CorrectRoadH
CorrectRoadH approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@CorrectRoadH CorrectRoadH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You can wait for the review from boojack. After it, the PR will be merged🥳

@titanventura titanventura requested a review from CorrectRoadH May 17, 2023 09:01
@titanventura
Copy link
Contributor Author

@boojack Any updates on this ?

@Zeng1998
Copy link
Contributor

I think we need to sort memos in the backend.

https://github.com/usememos/memos/blob/main/store/memo.go#LL287C24-L287C24

@boojack
Copy link
Collaborator

boojack commented May 29, 2023 •
edited
Loading

Implemented with #1760, #1761

Thanks for your contribution!

@boojack boojack closed this May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boojack boojack Awaiting requested review from boojack boojack is a code owner

@CorrectRoadH CorrectRoadH Awaiting requested review from CorrectRoadH

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sort memos by updatedTs
4 participants
@titanventura @Zeng1998 @boojack @CorrectRoadH