Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve Windows support #1645

Merged
merged 4 commits into from
May 10, 2023

Conversation

lincolnthalles
Copy link
Contributor

  • Fix local file storage path handling on Windows

  • Improve Windows dev script

development and production environments.

Default profile.Data will be set to "C:\ProgramData\memos" on Windows.
Folder will be created if it does not exist, as this behavior is
expected for Windows applications.

System service installation can be achieved with third-party tools,
explained in docs/windows-service.md.

Not sure if it's worth using https://github.com/kardianos/service
to make service support built-in.

This could be a nice addition alongside usememos#1583 (add Windows artifacts)
- Fix local file storage path handling on Windows

- Improve Windows dev script
@lincolnthalles lincolnthalles requested a review from boojack as a code owner May 9, 2023 09:17
@github-actions
Copy link

github-actions bot commented May 9, 2023

Uffizzi Preview deployment-24677 was deleted.

Copy link
Collaborator

@boojack boojack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@boojack boojack merged commit 5340008 into usememos:main May 10, 2023
@lincolnthalles lincolnthalles deleted the feat--add-basic-Windows-support branch May 13, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants