Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: read content from search params #1607

Merged
merged 1 commit into from
Apr 26, 2023
Merged

feat: read content from search params #1607

merged 1 commit into from
Apr 26, 2023

Conversation

benjick
Copy link
Contributor

@benjick benjick commented Apr 26, 2023

Wanted to add this feature to prefill the memo editor content from the URL.

Screenshot 2023-04-26 at 21 31 22

Had some trouble running the e2e tests, could someone tell me how to get them running so I can add tests if needed?

@benjick benjick requested a review from boojack as a code owner April 26, 2023 19:33
@github-actions
Copy link

github-actions bot commented Apr 26, 2023 •
edited
Loading

Uffizzi Preview deployment-23476 was deleted.

boojack
boojack approved these changes Apr 26, 2023
View reviewed changes
Copy link
Collaborator

@boojack boojack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution!

@boojack boojack merged commit dbb544d into usememos:main Apr 26, 2023
@benjick benjick deleted the feat/memo-editor/read-from-query-param branch April 27, 2023 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boojack boojack boojack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benjick @boojack