Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update save button style #1542

Merged
merged 1 commit into from
Apr 16, 2023
Merged

chore: update save button style #1542

merged 1 commit into from
Apr 16, 2023

Conversation

boojack
Copy link
Collaborator

@boojack boojack commented Apr 16, 2023 •
edited by ghost
Loading

🤖 Generated by Copilot at 5ee4119

Summary

📏🟢🛑

This pull request improves the web app's user interface by fixing some issues with scrolling, layout, and button design in the BaseDialog and LocaleSelect components and the memo-editor.less file.

Oh, we're the web devs of the sea, me hearties
We tweak the styles and fix the bugs with ease
We make the locale select fit and confirm button round
And stop the scroll when BaseDialog is on the ground

Walkthrough

  • Prevent scrolling behind open dialogs by adding and removing a class to the document body (link, link) in BaseDialog.tsx

@boojack boojack merged commit 5f8aae6 into main Apr 16, 2023
@boojack boojack deleted the chore/update-save-button-round branch April 25, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@boojack