Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: navigate faild silently #1300

Merged
merged 2 commits into from
Mar 7, 2023
Merged

fix: navigate faild silently #1300

merged 2 commits into from
Mar 7, 2023

Conversation

unliar
Copy link
Contributor

@unliar unliar commented Mar 7, 2023

reproduce: navigate from the home page / to /explore, then use the browser back button, navigate action will be failed and show a warning console log.
V4a2PecCGD

how to fix: upgrade the react-router version above 6.8.1.

react-router issue #9998

@unliar unliar requested a review from boojack as a code owner March 7, 2023 01:20
Copy link
Collaborator

@boojack boojack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@boojack boojack merged commit 7c5fae6 into usememos:main Mar 7, 2023
@unliar unliar deleted the fix-route-failed-silently branch March 7, 2023 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants