Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Tracking From Electron Applications #328

Merged
merged 1 commit into from
Mar 26, 2022
Merged

Allow Tracking From Electron Applications #328

merged 1 commit into from
Mar 26, 2022

Conversation

beeequeue
Copy link
Contributor

In Electron the application can be served from the file system, meaning tracking is impossible with the original check in place.

Electron apps have a user agent like

Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) {{app_name}}/{{app_version}} Chrome/83.0.4103.122 Electron/9.4.4 Safari/537.36

so we can check if it contains Electron and continue if it it does.

@JackEllis JackEllis assigned JackEllis and LKaemmerling and unassigned JackEllis Mar 26, 2022
@LKaemmerling LKaemmerling merged commit ba86af2 into usefathom:master Mar 26, 2022
@LKaemmerling
Copy link
Contributor

Hey @beeequeue,

thank you for your change. It will be in the next release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants