Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add SameSite and Secure attribute to cookie #314

Merged
merged 1 commit into from
Mar 26, 2022

Conversation

ThaneshR
Copy link
Contributor

@ThaneshR ThaneshR commented May 8, 2020

I noticed the following warning message in devtools after self-hosting fathom-lite:

A cookie associated with a cross-site resource at [my-url] was set without the SameSite attribute. A future release of Chrome will only deliver cookies with cross-site requests if they are set with SameSite=None and Secure. You can review cookies in developer tools under Application>Storage>Cookies and see more details at https://www.chromestatus.com/feature/5088147346030592 and https://www.chromestatus.com/feature/5633521622188032.

Here's an in-depth article explaining the purpose of the SameSite attribute: https://blog.heroku.com/chrome-changes-samesite-cookie.

I referred to this github example to add the SameSite and Secure attribute.

@ThaneshR ThaneshR changed the title added SameSite and Secure attribute add SameSite and Secure attribute May 8, 2020
@ThaneshR ThaneshR changed the title add SameSite and Secure attribute add SameSite and Secure attribute to cookie May 8, 2020
@wgroeneveld
Copy link

Great. I'd love to get this included.

@JackEllis
Copy link
Collaborator

Agreed, we should do this!

@LKaemmerling LKaemmerling merged commit 81ace48 into usefathom:master Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants