Change tracker.js Cache-Control header to no-store #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to all documentation I can find, `no-store` is the strongest "do not cache" `Cache-Control` header there is, and `no-cache` and `must-revalidate` are strictly weaker and will have no effect when `no-store` is present. Additionally, I cannot find any evidence that these other values are useful for backwards compatibility or older browsers, and `no-store` support appears to be universal. Lastly, webhint.io is specifically telling me that I should not use `must-revalidate`.
m1guelpf
approved these changes
Feb 4, 2020
|
Thanks @JacobEvelyn (and @m1guelpf for getting this to the top). We'll merge it in and then recompile in the future when we do our new release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to all documentation I can find,
no-storeis the strongest "do not cache"Cache-Controlheader there is, andno-cacheandmust-revalidateare strictly weaker and will have no effect whenno-storeis present. Additionally, I cannot find any evidence that these other values are useful for backwards compatibility or older browsers, andno-storesupport appears to be universal. Lastly, webhint.io is specifically telling me that I should not usemust-revalidate.