Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Accessibility of tracker.js #184

Merged
merged 1 commit into from
Nov 17, 2018
Merged

Improve Accessibility of tracker.js #184

merged 1 commit into from
Nov 17, 2018

Conversation

Empty2k12
Copy link
Contributor

fathom is creating an image element for tracking which is not accessibility compliant.

This severely lowers my https://web.dev/measure score.

screenshot 2018-11-16 at 15 32 50 redacted

This PR is adding an empty alt tag and the aria-hidden tag to indicate irrelevance of the image to screenreaders.

To tell assistive technology to ignore an image, use a "blank alternative text" attribute: alt="".
https://dequeuniversity.com/rules/axe/2.2/image-alt?application=lighthouse

@dannyvankooten dannyvankooten merged commit a66f9ed into usefathom:master Nov 17, 2018
@dannyvankooten
Copy link
Contributor

Makes total sense. Thank you @Empty2k12!

@Empty2k12 Empty2k12 deleted the tracker-accessibility branch November 19, 2018 10:32
@Empty2k12
Copy link
Contributor Author

Awesome, thanks for merging so quickly. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Empty2k12 @dannyvankooten