make SiteSwitcher work on touch devices #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @samuelmeuli, On which touch devices is this specifically? Because I was under the impression that on touch devices, the hover event was triggered when tapping the element and my tests on iPhone & Nexus seem to confirm that. |
|
Weird. I'm also using an iPhone (Safari, iOS 12) and it's not working for me. I can get the dropdown to open by tapping on the |
|
Sorry for the wait on this one. It seems to be affecting Safari on iOS, but not Chrome or Firefox. Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it possible to use the SiteSwitcher on touch devices. This wasn't possible before because opening it required the user to hover on the dropdown.