Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine paths with and without trailing slash #269

Closed
weavermedia opened this issue May 30, 2019 · 4 comments · Fixed by #348
Closed

Combine paths with and without trailing slash #269

weavermedia opened this issue May 30, 2019 · 4 comments · Fixed by #348
Assignees
@LKaemmerling
Labels
bug

Comments

@weavermedia
Copy link

I'm seeing separate entries for /about and /about/.

I understand these are technically different resources but for analytics wouldn't the count for these two paths be better combined?
@JackEllis
Copy link
Collaborator

Agreed!

@stef7
Copy link

stef7 commented Aug 13, 2021

Also agreed...

@JackEllis JackEllis added the bug label Apr 7, 2022
@JackEllis
Copy link
Collaborator

Would expect a 'right trim' on the /. Could cause issues for folks who NEED a trailing slash, but seems like that won't be many.

LKaemmerling added a commit that referenced this issue May 2, 2022
@LKaemmerling
Combine paths with and without trailing slash
b05e27d 
Closes #269
Signed-off-by: Lukas Kämmerling <[email protected]>
@LKaemmerling LKaemmerling mentioned this issue May 2, 2022
Merged
@snyk-bot snyk-bot mentioned this issue Mar 14, 2023
Open
@olets
Copy link

olets commented Dec 8, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LKaemmerling LKaemmerling

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Combine paths with and without trailing slash usefathom/fathom
5 participants
@JackEllis @stef7 @weavermedia @olets @LKaemmerling