Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why is "aria-hidden" attribute used on tracking img? #234

Closed
khaskelberg opened this issue Feb 20, 2019 · 0 comments · Fixed by #352
Closed

Why is "aria-hidden" attribute used on tracking img? #234

khaskelberg opened this issue Feb 20, 2019 · 0 comments · Fixed by #352
Assignees
@LKaemmerling
Labels
bug

Comments

@khaskelberg
Copy link

khaskelberg commented Feb 20, 2019 •
edited
Loading

Is there a reason you use "aria-hidden" attribute and not "hidden" in trackPageview?

fathom/assets/src/js/tracker.js

Line 177 in 5e4ce53

img.setAttribute('aria-hidden', 'true');

"aria-hidden" creates awkward situation with scroll bar if there is a div with min-height: 100vh
peek 2019-02-20 13-56

As you can see sidebar appeared and then disappeared because of the appended img.

I did a quick test replacing "aria-hidden" with "hidden" and everything seemed to work
@JackEllis JackEllis added the next release We will include this in the next releaase label Mar 20, 2019
@JackEllis JackEllis added bug and removed next release We will include this in the next releaase labels Apr 7, 2022
LKaemmerling added a commit that referenced this issue May 2, 2022
@LKaemmerling
Tracking img set style to position:absolute
1d0ca9f 
This is based on feedback i got from Jack, let's pray that fixes it.

(Hopefully) Closes #234
@LKaemmerling LKaemmerling mentioned this issue May 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LKaemmerling LKaemmerling

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tracking img set style to position:absolute usefathom/fathom
3 participants
@JackEllis @LKaemmerling @khaskelberg