-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ALT + arrow-key doesn't work #138
Comments
Hey @RadhiFadlillah, That's weird, it definitely does for me in Firefox Nightly and Firefox itself and I can't find any default browser shortkey on that link either. (There is one for Could it be that it the shortkey isn't working because your browser window does not have focus? |
I'm sorry, I forgot to tell that I'm using Firefox 62.0.2 in Manjaro Linux 64-bit. In Linux, Firefox uses Alt + Left for going back and Alt + Right for going forward : AFAIK Chrome also uses the same shortcut for Windows and Linux : |
I'm willing to submit a PR for updating the shortcut. Any suggestions for what that should be? |
@bigblind That'd be so awesome! I have yet to check what keys browsers deem safe to use in "user-land" but I was thinking of using the regular arrow-keys unless an input field has focus (if the event still fires then, I am not sure without checking). |
Ok, that should be easy to check using event.target.
…On Tue, 2 Oct 2018 at 2:57 PM, Danny van Kooten ***@***.***> wrote:
@bigblind <https://github.com/bigblind> That'd be so awesome! I have yet
to check what keys browsers deem safe to use in "user-land" but I was
thinking of using the regular arrow-keys *unless* an input field has
focus (if the event still fires then, I am not sure without checking).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#138 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAtA1RmNtW1crErKrdpf7tVJXjD9dKwxks5ug2LKgaJpZM4W4m8j>
.
|
In the analytic page, it said "Use ALT + arrow-key to cycle through date ranges". However, in Firefox 62.0.2, Alt + row-key is already used for shortcut, so it doesnt work as intended.
The text was updated successfully, but these errors were encountered: