Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALT + arrow-key doesn't work #138

Closed
RadhiFadlillah opened this issue Sep 25, 2018 · 5 comments · Fixed by #147
Closed

ALT + arrow-key doesn't work #138

RadhiFadlillah opened this issue Sep 25, 2018 · 5 comments · Fixed by #147

Comments

@RadhiFadlillah
Copy link

In the analytic page, it said "Use ALT + arrow-key to cycle through date ranges". However, in Firefox 62.0.2, Alt + row-key is already used for shortcut, so it doesnt work as intended.

@dannyvankooten
Copy link
Contributor

Hey @RadhiFadlillah,

That's weird, it definitely does for me in Firefox Nightly and Firefox itself and I can't find any default browser shortkey on that link either. (There is one for Cmd + Alt + Arrow-key but not without Cmd IIUC).

Could it be that it the shortkey isn't working because your browser window does not have focus?

@RadhiFadlillah
Copy link
Author

Hi @dannyvankooten

That's weird, it definitely does for me in Firefox Nightly and Firefox. I can't find any default browser shortkey on that link either.

I'm sorry, I forgot to tell that I'm using Firefox 62.0.2 in Manjaro Linux 64-bit. In Linux, Firefox uses Alt + Left for going back and Alt + Right for going forward :

shortcut firefox

AFAIK Chrome also uses the same shortcut for Windows and Linux :

shortcut-chrome

@frederikcreemers
Copy link
Contributor

frederikcreemers commented Oct 2, 2018

I'm willing to submit a PR for updating the shortcut. Any suggestions for what that should be?

@dannyvankooten
Copy link
Contributor

@bigblind That'd be so awesome! I have yet to check what keys browsers deem safe to use in "user-land" but I was thinking of using the regular arrow-keys unless an input field has focus (if the event still fires then, I am not sure without checking).

@frederikcreemers
Copy link
Contributor

frederikcreemers commented Oct 2, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants