Merge pull request #147 from bigblind/master

Use arrows (without alt) to go through date ranges. Thanks @bigblind!
usefathom · Oct 5, 2018 · 8515ba6 · 8515ba6
2 parents c9b95fa + 181bee7
commit 8515ba6
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/assets/src/js/components/DatePicker.js b/assets/src/js/components/DatePicker.js
@@ -162,7 +162,9 @@ class DatePicker extends Component {
 
   @bind
   handleKeyPress(evt) {
-    if( ! evt.altKey ) {
+    // Don't handle input when the user is in a text field or text area.
+    let tag = event.target.tagName;
+    if(tag === "INPUT" || tag === "TEXTAREA") {
       return;
     }
 
@@ -171,14 +173,14 @@ class DatePicker extends Component {
     let newStartDate, newEndDate;
 
     switch(evt.keyCode) {
-      // ALT + left-arrow
+      // left-arrow
       case 37:
         newStartDate = new Date(+this.state.startDate - diff)
         newEndDate = new Date(+this.state.endDate - diff)
         this.setDateRange(newStartDate, newEndDate)
       break;
 
-      // ALT + right-arrow
+      //right-arrow
       case 39:
       newStartDate = new Date(+this.state.startDate + diff)
       newEndDate = new Date(+this.state.endDate + diff)

diff --git a/assets/src/js/pages/dashboard.js b/assets/src/js/pages/dashboard.js
@@ -69,7 +69,7 @@ class Dashboard extends Component {
         </div>
 
         <div class="footer hide-on-mobile">
-          <p>Use <strong>ALT + arrow-key</strong> to cycle through date ranges.</p>
+          <p>Use <strong>the arrow keys</strong> to cycle through date ranges.</p>
         </div>
       </section>