-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Chore/relock #7606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/relock #7606
Changes from 7 commits
42e7d3f
7450f52
41156e6
9113e69
ada9803
92c0c21
4e143ac
c9945ed
2f46706
0993fb1
e57b8ac
7ed4826
be9f348
4c5c039
1cfe0dd
37aca38
d6d9652
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -43,18 +43,18 @@ export const mockDataFunctions = { | |||||||||||||||||||||||||||||||||||||||||||||||||
| randomLongitude: () => faker.location.longitude(), | ||||||||||||||||||||||||||||||||||||||||||||||||||
| randomAvatarImage: () => faker.image.avatar(), | ||||||||||||||||||||||||||||||||||||||||||||||||||
| randomImageUrl: () => faker.image.url(), | ||||||||||||||||||||||||||||||||||||||||||||||||||
| randomAbstractImage: () => faker.image.urlLoremFlickr({ category: 'abstract' }), | ||||||||||||||||||||||||||||||||||||||||||||||||||
| randomAnimalsImage: () => faker.image.urlLoremFlickr({ category: 'animals' }), | ||||||||||||||||||||||||||||||||||||||||||||||||||
| randomBusinessImage: () => faker.image.urlLoremFlickr({ category: 'business' }), | ||||||||||||||||||||||||||||||||||||||||||||||||||
| randomCatsImage: () => faker.image.urlLoremFlickr({ category: 'cats' }), | ||||||||||||||||||||||||||||||||||||||||||||||||||
| randomCityImage: () => faker.image.urlLoremFlickr({ category: 'city' }), | ||||||||||||||||||||||||||||||||||||||||||||||||||
| randomFoodImage: () => faker.image.urlLoremFlickr({ category: 'food' }), | ||||||||||||||||||||||||||||||||||||||||||||||||||
| randomNightlifeImage: () => faker.image.urlLoremFlickr({ category: 'nightlife' }), | ||||||||||||||||||||||||||||||||||||||||||||||||||
| randomFashionImage: () => faker.image.urlLoremFlickr({ category: 'fashion' }), | ||||||||||||||||||||||||||||||||||||||||||||||||||
| randomPeopleImage: () => faker.image.urlLoremFlickr({ category: 'people' }), | ||||||||||||||||||||||||||||||||||||||||||||||||||
| randomNatureImage: () => faker.image.urlLoremFlickr({ category: 'nature' }), | ||||||||||||||||||||||||||||||||||||||||||||||||||
| randomSportsImage: () => faker.image.urlLoremFlickr({ category: 'sports' }), | ||||||||||||||||||||||||||||||||||||||||||||||||||
| randomTransportImage: () => faker.image.urlLoremFlickr({ category: 'transport' }), | ||||||||||||||||||||||||||||||||||||||||||||||||||
| randomAbstractImage: () => faker.image.urlPicsumPhotos(), | ||||||||||||||||||||||||||||||||||||||||||||||||||
| randomAnimalsImage: () => faker.image.urlPicsumPhotos(), | ||||||||||||||||||||||||||||||||||||||||||||||||||
| randomBusinessImage: () => faker.image.urlPicsumPhotos(), | ||||||||||||||||||||||||||||||||||||||||||||||||||
| randomCatsImage: () => faker.image.urlPicsumPhotos(), | ||||||||||||||||||||||||||||||||||||||||||||||||||
| randomCityImage: () => faker.image.urlPicsumPhotos(), | ||||||||||||||||||||||||||||||||||||||||||||||||||
| randomFoodImage: () => faker.image.urlPicsumPhotos(), | ||||||||||||||||||||||||||||||||||||||||||||||||||
| randomNightlifeImage: () => faker.image.urlPicsumPhotos(), | ||||||||||||||||||||||||||||||||||||||||||||||||||
| randomFashionImage: () => faker.image.urlPicsumPhotos(), | ||||||||||||||||||||||||||||||||||||||||||||||||||
| randomPeopleImage: () => faker.image.urlPicsumPhotos(), | ||||||||||||||||||||||||||||||||||||||||||||||||||
| randomNatureImage: () => faker.image.urlPicsumPhotos(), | ||||||||||||||||||||||||||||||||||||||||||||||||||
| randomSportsImage: () => faker.image.urlPicsumPhotos(), | ||||||||||||||||||||||||||||||||||||||||||||||||||
| randomTransportImage: () => faker.image.urlPicsumPhotos(), | ||||||||||||||||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||||||||||||||||
| randomAbstractImage: () => faker.image.urlPicsumPhotos(), | |
| randomAnimalsImage: () => faker.image.urlPicsumPhotos(), | |
| randomBusinessImage: () => faker.image.urlPicsumPhotos(), | |
| randomCatsImage: () => faker.image.urlPicsumPhotos(), | |
| randomCityImage: () => faker.image.urlPicsumPhotos(), | |
| randomFoodImage: () => faker.image.urlPicsumPhotos(), | |
| randomNightlifeImage: () => faker.image.urlPicsumPhotos(), | |
| randomFashionImage: () => faker.image.urlPicsumPhotos(), | |
| randomPeopleImage: () => faker.image.urlPicsumPhotos(), | |
| randomNatureImage: () => faker.image.urlPicsumPhotos(), | |
| randomSportsImage: () => faker.image.urlPicsumPhotos(), | |
| randomTransportImage: () => faker.image.urlPicsumPhotos(), | |
| randomAbstractImage: () => faker.image.urlLoremFlickr({ category: 'abstract' }), | |
| randomAnimalsImage: () => faker.image.urlLoremFlickr({ category: 'animals' }), | |
| randomBusinessImage: () => faker.image.urlLoremFlickr({ category: 'business' }), | |
| randomCatsImage: () => faker.image.urlLoremFlickr({ category: 'cats' }), | |
| randomCityImage: () => faker.image.urlLoremFlickr({ category: 'city' }), | |
| randomFoodImage: () => faker.image.urlLoremFlickr({ category: 'food' }), | |
| randomNightlifeImage: () => faker.image.urlLoremFlickr({ category: 'nightlife' }), | |
| randomFashionImage: () => faker.image.urlLoremFlickr({ category: 'fashion' }), | |
| randomPeopleImage: () => faker.image.urlLoremFlickr({ category: 'people' }), | |
| randomNatureImage: () => faker.image.urlLoremFlickr({ category: 'nature' }), | |
| randomSportsImage: () => faker.image.urlLoremFlickr({ category: 'sports' }), | |
| randomTransportImage: () => faker.image.urlLoremFlickr({ category: 'transport' }), |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,7 +29,7 @@ | |
| ] | ||
| }, | ||
| "dependencies": { | ||
| "@aws-sdk/credential-providers": "3.750.0", | ||
| "@aws-sdk/credential-providers": "3.1019.0", | ||
| "@grpc/grpc-js": "^1.13.2", | ||
| "@grpc/proto-loader": "^0.7.13", | ||
| "@lydell/node-pty": "^1.1.0", | ||
|
|
@@ -82,7 +82,7 @@ | |
| }, | ||
| "devDependencies": { | ||
| "electron": "~37.6.1", | ||
| "electron-builder": "^24.13.3", | ||
| "electron-builder": "^26.8.1", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🌐 Web query:
💡 Result: electron-builder v26 (released January 2025 as the major version after v25) introduced several significant changes, primarily around dependency collection, packaging, and platform-specific improvements. While not explicitly labeled as "breaking changes" in the official changelog, early v26.x releases (starting ~v26.0.4) had regressions that broke builds for some users, particularly around native module handling and node_modules collection. These were fixed in subsequent patches. Key changes in v26.0.0 (from GitHub PR Citations:
🏁 Script executed: find . -name "*electron-builder*" -type f | grep -E "\.(js|json|config)" | head -20Repository: usebruno/bruno Length of output: 110 🏁 Script executed: cat -n ./packages/bruno-electron/electron-builder-config.jsRepository: usebruno/bruno Length of output: 3305 🌐 Web query:
💡 Result: In electron-builder v26.0.0 (released January 2025), deprecated signing configuration fields were removed from the top-level win options object as a breaking change. Previously available signing options like certificateFile, certificatePassword, certificateSubjectName, publisherName, signingHashAlgorithms, etc., which were directly under win (sometimes referred to as winOptions), have been removed. These options have been restructured: - Standard signtool.exe signing configuration is now nested under win.signtoolOptions. - Azure Trusted Signing configuration is under win.azureSignOptions. This cleanup was done to support separate Azure signing configuration without bloating the win object and to remove long-deprecated fields. The change was implemented in PR Citations:
Review electron-builder v26 Windows signing config structure. electron-builder v26 removed deprecated signing fields ( 🤖 Prompt for AI Agents |
||
| "electron-devtools-installer": "^4.0.0" | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,22 +19,22 @@ | |
| "@types/markdown-it": "^12.2.3", | ||
| "@types/react": "^18.0.25", | ||
| "graphql": "^16.6.0", | ||
| "markdown-it": "^13.0.1", | ||
| "markdown-it": "^14.1.1", | ||
|
coderabbitai[bot] marked this conversation as resolved.
Outdated
|
||
| "postcss": "8.4.47", | ||
| "react": "19.0.0", | ||
| "react-dom": "18.2.0", | ||
| "rollup":"3.29.5", | ||
| "rollup":"3.30.0", | ||
|
||
| "rollup-plugin-dts": "^5.0.0", | ||
| "rollup-plugin-peer-deps-external": "^2.2.4", | ||
| "rollup-plugin-postcss": "^4.0.2", | ||
| "rollup-plugin-terser": "^7.0.2", | ||
| "typescript": "^4.8.4" | ||
| "typescript": "^5.8.3" | ||
| }, | ||
| "peerDependencies": { | ||
| "graphql": "^16.6.0", | ||
| "markdown-it": "^13.0.1" | ||
| }, | ||
| "overrides": { | ||
| "rollup":"3.29.5" | ||
| "rollup":"3.30.0" | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,7 +2,7 @@ const { nodeResolve } = require("@rollup/plugin-node-resolve"); | |
| const commonjs = require("@rollup/plugin-commonjs"); | ||
| const typescript = require("@rollup/plugin-typescript"); | ||
| const dts = require("rollup-plugin-dts"); | ||
| const { terser } = require("rollup-plugin-terser"); | ||
| const terser = require("@rollup/plugin-terser"); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Use single quotes for the import string. Line 5 uses double quotes; this should be single quotes to match repo conventions. Suggested fix-const terser = require("@rollup/plugin-terser");
+const terser = require('@rollup/plugin-terser');As per coding guidelines: “Stick to single quotes for strings.” 🤖 Prompt for AI Agents |
||
| const peerDepsExternal = require('rollup-plugin-peer-deps-external'); | ||
|
|
||
| const packageJson = require("./package.json"); | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new
overridesentries forajvandqsare ranges (^...). Overrides are typically used to force a specific version for reproducibility/security; using a range can allow unexpected future upgrades. Consider pinning exact versions here (consistent with therollupoverride).