sanitize the imported environment filename before writing it to disk #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cardonator
force-pushed
the
bugfix/#662
branch
from
516ea33 to
0eb221c
Compare
|
Hey @cardonator, In #349 I already implemented a meta tag/grammar in the environment files to save the name. With this, you can use any character in the environment name. The PR is planned to be reviewed and merged before the v1 release, so it should be shipped shortly! I really appreciate your afford, but I think your PR obsolete. |
|
@Its-treason sweet, thanks. You're right that the proposed change will make this change obsolete. I'll take a look at and comment on that other PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently if the environment name has a bad character (like /) in it then it fails to write to the filesystem. I'm proposing this however I don't think this is functional to merge because of #663 right now. The Environment name on the UI ends up being the filename and it really should be a name stored in the environment file and not just the filename.
Contribution Checklist:
Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.