Deliver Dedot & Typink M1

[sinzii]

Deliver M1 for Dedot & Typink (PR).

We're happy to answer any questions or hop on a call to discuss the changes in details if needed. Thanks!

[TtomaS7]

🎉 Thank you so much for your first delivery!
We really appreciate the effort you put into completing M1 for Dedot & Typink. Everything looks great at first glance — we'll review the changes shortly and get back to you if we have any questions.

[sinzii]

FYI, we've just release dedot v0.14.0 bringing 2 more important improvements for contract interactions

1. Automatic dry-run for contract transactions, so devs now don't have to do manual dry-run before making transactions.
2. Unified APIs for contract address calculation and instance initialization, so devs no longer have to use clunky methods like CREATE1 or CREATE2 to calculate contract address.

[al3mart]

Hi @sinzii thanks for the milestone delivery!

I've had now finished my review of this milestone, here is some feedback:

• I was able to follow the examples, tests and docs provided without encountering any errors.
• Having a possibility of reading the contract state while avoiding calls to the contract while possible seems like a sensible approach.
• In your PR#479 there's a mention to the Instantiated event being removed. It was added back in PR#8799, hopefully this is good news.
• Regarding the challenges presented around not being able to incorporate native EVM wallets: I can understand this might have been over scoped, as you mentioned the changes to your library will be significant. I would like to hear what is your view on this. Is this something you might want to push into a later milestone or is this something you are more comfortable discarding from the scope of this grant.

I'd wait for you input on the above, but aside from that I'd be happy to accept this delivery and move forward.

[sinzii]

Thank you @al3mart for the review!

In your dedotdev/dedot#479 there's a mention to the Instantiated event being removed. It was added back in paritytech/polkadot-sdk#8789, hopefully this is good news.

Yes we're aware of this and we plan to support this when it's get released in the upcoming version of polkdaot-sdk as well as ink-node.

Is this something you might want to push into a later milestone or is this something you are more comfortable discarding from the scope of this grant.

As you might already know, the new Ethereum RPCs are running on a different proxy server separately from the usual Substrate Websocket RPC Server. This might resulting us having to create a whole new different JsonRpcProvider & Client to support interact with this set of Ethereum RPC methods. Though this might be an interesting feature to pursue, but given its complexity, I would be more comfortable leaving this out of the scope of this grant and fully focus on supporting ink! v6 and pallet-revive interaction & related tooling/UI.

Please note that since native EVM wallets integration is excluded from the scope of this grant, we will instead focus on adding more features to Dedot and Typink to better support ink! v6 — such as direct contract storage interaction, automatic dry-run execution, and gas fee estimation etc ... as mentioned in the delivery.

Let me know if you have any other questions or steps to take to move this forward! 🙏

[al3mart]

As you might already know, the new Ethereum RPCs are running on a different proxy server separately from the usual Substrate Websocket RPC Server. This might resulting us having to create a whole new different JsonRpcProvider & Client to support interact with this set of Ethereum RPC methods. Though this might be an interesting feature to pursue, but given its complexity, I would be more comfortable leaving this out of the scope of this grant and fully focus on supporting ink! v6 and pallet-revive interaction & related tooling/UI.

Please note that since native EVM wallets integration is excluded from the scope of this grant, we will instead focus on adding more features to Dedot and Typink to better support ink! v6 — such as direct contract storage interaction, automatic dry-run execution, and gas fee estimation etc ... as mentioned in the delivery.

Let me know if you have any other questions or steps to take to move this forward! 🙏

I can understand your position. No push back from my side. Once this milestone is officially approved (need two curator approvals) I'd suggest pushing an addendum to the original proposal clarifying that no EVM wallet compat should be expected.

Thanks for the great work.

[davidsemakula]

LGTM as well!

@sinzii Please make an amendment PR that reflects removal of EVM wallet support from the scope so that other curators can sign off on this change for the rest of the milestones.

For this PR/milestone, @al3mart and I have basically overlooked this change to the scope because we both think the replacement is objectively useful and not too controversial. However, in the future, please try to get amendments approved first before delivery.

Apart from that, thanks a lot for the great work! 🙂

[TtomaS7]

Hey team! 🎉
Huge congrats on the delivery!

To get your payment rolling, please fill out this form: https://forms.gle/xPfZw6K2SzdACgpr6
When you submit, add a quick note about what the payment’s for - feel free to drop the link to this PR under “Please describe which Milestone you have completed and attach the link to the Milestone delivery.”

Important: double‑check the wallet/address where you want to receive the funds before hitting “Submit.” ✅

Thanks so much!

[sinzii]

Thank you everyone for the reviews and approvals. I've just submitted the payment form!

I'll also soon submit an amendment PR to remove the EVM wallet support out of the scope of this proposal, thanks!

[TtomaS7]

Hey team! 🎉
Huge thanks for your delivery!

We’ve already processed the payment for this milestone ✅
Here’s the link to the transaction: https://polkadot.subsquare.io/treasury/child-bounties/19_6

Really appreciate your work and looking forward to the next milestone. Closing this PR now.

Thanks so much! 🙌