Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lang] Improve invalid selector error #561

Merged
merged 10 commits into from
Nov 4, 2020
Merged

[lang] Improve invalid selector error #561

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
581529f
[lang] Improve invalid selector message
cmichi Nov 3, 2020
1dd2fd6
[lang] Improve span
cmichi Nov 3, 2020
8500eed
[lang] Return syn::Error instead of panicking
cmichi Nov 3, 2020
32bd955
Merge branch 'master' into cmichi-improve-invalid-selector-error
cmichi Nov 3, 2020
db366f2
Make clippy happy
cmichi Nov 3, 2020
ec9657f
[lang] Reduce code dup with non_hex_err
cmichi Nov 4, 2020
e1c2d7e
[lang] Rename fn
cmichi Nov 4, 2020
31c65fe
[lang] Fix err functions
cmichi Nov 4, 2020
5750f44
[lang] Add comments
cmichi Nov 4, 2020
809fb97
[lang] Remove unnecessary lifetime
cmichi Nov 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 32 additions & 14 deletions crates/lang/ir/src/ir/attrs.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,24 +580,42 @@ impl TryFrom<syn::NestedMeta> for AttributeArg {
).map_err(|_| {
format_err_spanned!(
meta,
"invalid selector bytes"
"invalid selector - a selector must consist of four bytes in hex (e.g. `selector = \"0xCAFEBABE\"`)"
)
})?;
let str = lit_str.value();
let cap = regex.captures(&str).unwrap();
let cap = regex.captures(&str)
.ok_or(
format_err_spanned!(
meta,
"invalid selector - a selector must consist of four bytes in hex (e.g. `selector = \"0xCAFEBABE\"`)"
)
cmichi marked this conversation as resolved.
Show resolved Hide resolved
)?;
let selector_bytes = [
u8::from_str_radix(&cap[1], 16).expect(
"encountered non-hex digit at position 0",
),
u8::from_str_radix(&cap[2], 16).expect(
"encountered non-hex digit at position 1",
),
u8::from_str_radix(&cap[3], 16).expect(
"encountered non-hex digit at position 2",
),
u8::from_str_radix(&cap[4], 16).expect(
"encountered non-hex digit at position 3",
),
u8::from_str_radix(&cap[1], 16).map_err(|_| {
format_err_spanned!(
meta,
"encountered non-hex digit at position 0",
)
cmichi marked this conversation as resolved.
Show resolved Hide resolved
})?,
u8::from_str_radix(&cap[2], 16).map_err(|_| {
format_err_spanned!(
meta,
"encountered non-hex digit at position 1",
)
})?,
u8::from_str_radix(&cap[3], 16).map_err(|_| {
format_err_spanned!(
meta,
"encountered non-hex digit at position 2",
)
})?,
u8::from_str_radix(&cap[4], 16).map_err(|_| {
format_err_spanned!(
meta,
"encountered non-hex digit at position 3",
)
})?,
];
return Ok(AttributeArg {
ast: meta,
Expand Down
1 change: 1 addition & 0 deletions crates/lang/macro/tests/compile_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ fn compile_tests() {
t.compile_fail("tests/ui/fail/M-02-message-missing-self-arg.rs");
t.compile_fail("tests/ui/fail/M-03-message-returns-self.rs");
t.compile_fail("tests/ui/fail/M-04-message-returns-non-codec.rs");
t.compile_fail("tests/ui/fail/M-05-message-invalid-selector.rs");
t.compile_fail("tests/ui/fail/M-10-method-unknown-ink-marker.rs");

t.compile_fail("tests/ui/fail/S-01-missing-storage-struct.rs");
Expand Down
19 changes: 19 additions & 0 deletions crates/lang/macro/tests/ui/fail/M-05-message-invalid-selector.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
use ink_lang as ink;

#[ink::contract]
mod message_invalid_selector {
#[ink(storage)]
pub struct MessageInvalidSelector {}

impl MessageInvalidSelector {
#[ink(constructor)]
pub fn constructor() -> Self {
Self {}
}

#[ink(message, selector = "0x00")]
pub fn invalid_selector(&self) { }
}
}

fn main() {}
5 changes: 5 additions & 0 deletions crates/lang/macro/tests/ui/fail/M-05-message-invalid-selector.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
error: invalid selector - a selector must consist of four bytes in hex (e.g. `selector = "0xCAFEBABE"`)
--> $DIR/M-05-message-invalid-selector.rs:14:24
|
14 | #[ink(message, selector = "0x00")]
| ^^^^^^^^^^^^^^^^^