Conversation
Co-authored-by: Michael Müller <mich@elmueller.net>
|
@LucasGrasso If you check the diff of this PR something is strange (see e.g. the changes to |
|
@cmichi I think its ok now, my IDE autoformatted the changelog file, so I just copied and pasted the one in use-ink/ink/master. |
There was a problem hiding this comment.
Thanks @LucasGrasso
A few notes/comments, but I'll let @cmichi have the last word.
Edit: Also, you can ignore the CI failure for the examples-test (2) job, it's unrelated to your changes.
|
@davidsemakula Thanks for your comments, implemented the changes you mentioned, they made sense to me. Can rollback if you want tho. |
There was a problem hiding this comment.
@LucasGrasso RE: #2694 (comment)
Added as a suggestion for clarity 🙂
Co-authored-by: David Semakula <davidsemakula@users.noreply.github.com>
cmichi
left a comment
There was a problem hiding this comment.
I've left soft changes to the comments. Can you adapt the example contract + other functions to the same changes?
|
@cmichi done, added evm opcodes and modified comments of functions related to this pr and |
cmichi
left a comment
There was a problem hiding this comment.
Thanks for the PR! Looks good besides the nits.
After applying them you'll most likely have to run cargo fmt locally, as the length of the line will be too long.
Use
cd ink/
fd Cargo.toml | xargs -n1 -I{} bash -c "echo {}; cargo +nightly fmt --manifest-path={}"
to apply it through the codebase and all examples (which are not in the workspace).
Co-authored-by: Michael Müller <mich@elmueller.net>
|
Thanks for your help!
Applied suggestions and no further formatting changes where needed after running the script locally |
Summary
Partially addresses #2653
cargo-contractorpallet-revive?Description
Implements the following host fns
fn gas_price() -> u64fn call_data_size() -> u64fn return_data_size() -> u64fn ref_time_left() -> u64