-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix port passing from node process #2336
Conversation
6ff320f
to
7c8b78a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2336 +/- ##
==========================================
+ Coverage 60.79% 60.83% +0.04%
==========================================
Files 141 141
Lines 5823 5829 +6
Branches 2414 2419 +5
==========================================
+ Hits 3540 3546 +6
Misses 2283 2283 ☔ View full report in Codecov by Sentry. |
* Have port parsing handle comma-separated list * Update changelog
🦑 📈 ink! Example Contracts ‒ Changes Report 📉 🦑These are the results when building the
Link to the run | Last update: Wed Dec 4 12:55:45 CET 2024 |
* Bump version to 5.1.1 * Fix port passing from node process (#2336) * Have port parsing handle comma-separated list * Update changelog
Closes #2335.
I'll make sure the CI would have catched this in a follow-up PR. The solution there is to migrate to our own Docker image for the CI, the Parity one hasn't been updated in months.