Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix port passing from node process #2336

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

cmichi
Copy link
Collaborator

@cmichi cmichi commented Dec 4, 2024

Closes #2335.

I'll make sure the CI would have catched this in a follow-up PR. The solution there is to migrate to our own Docker image for the CI, the Parity one hasn't been updated in months.

@cmichi cmichi requested a review from ascjones as a code owner December 4, 2024 10:19
@cmichi cmichi force-pushed the cmichi-fix-port-passing-from-node-process branch from 6ff320f to 7c8b78a Compare December 4, 2024 10:24
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 60.83%. Comparing base (93d1c3e) to head (7c8b78a).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
crates/e2e/src/node_proc.rs 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2336      +/-   ##
==========================================
+ Coverage   60.79%   60.83%   +0.04%     
==========================================
  Files         141      141              
  Lines        5823     5829       +6     
  Branches     2414     2419       +5     
==========================================
+ Hits         3540     3546       +6     
  Misses       2283     2283              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmichi cmichi merged commit 92a62a7 into master Dec 4, 2024
35 checks passed
@cmichi cmichi deleted the cmichi-fix-port-passing-from-node-process branch December 4, 2024 11:20
cmichi added a commit that referenced this pull request Dec 4, 2024
* Have port parsing handle comma-separated list

* Update changelog
@cmichi cmichi mentioned this pull request Dec 4, 2024
Copy link

github-actions bot commented Dec 4, 2024

🦑 📈 ink! Example Contracts ‒ Changes Report 📉 🦑

These are the results when building the integration-tests/* contracts from this branch with cargo-contract and comparing them to ink! master:

Contract Upstream Size (kB) PR Size (kB) Diff (kB) Diff (%) Change
call-builder-return-value 8.924 8.924 0 0
e2e-runtime-only-backend 1.925 1.925 0 0
lang-err/call-builder-delegate 2.612 2.612 0 0
lang-err/call-builder 5.66 5.66 0 0
lang-err/constructors-return-value 2.011 2.011 0 0
lang-err/contract-ref 5.087 5.087 0 0
lang-err/integration-flipper 1.91 1.91 0 0
mother 12.375 12.375 0 0
sr25519-verification 1.082 1.082 0 0
storage-types 10.935 10.935 0 0
call-runtime 1.881 1.881 0 0
combined-extension 2.046 2.046 0 0
conditional-compilation 1.46 1.46 0 0
contract-storage 7.459 7.459 0 0
contract-terminate 1.314 1.314 0 0
contract-transfer 1.52 1.52 0 0
contract-xcm 18.805 18.805 0 0
cross-contract-calls 7.471 7.471 0 0
cross-contract-calls/other-contract 1.591 1.591 0 0
custom-allocator 7.831 7.831 0 0
custom-environment 2.062 2.062 0 0
dns 7.142 7.142 0 0
e2e-call-runtime 1.182 1.182 0 0
erc1155 14.294 14.294 0 0
erc20 6.993 6.993 0 0
erc721 9.754 9.754 0 0
events 4.955 4.955 0 0
flipper 1.701 1.701 0 0
incrementer 1.538 1.538 0 0
lazyvec 4.664 4.664 0 0
mapping 8.008 8.008 0 0
multi-contract-caller 6.42 6.42 0 0
multi-contract-caller/accumulator 1.363 1.363 0 0
multi-contract-caller/adder 1.733 1.733 0 0
multi-contract-caller/subber 1.751 1.751 0 0
multisig 20.804 20.804 0 0
payment-channel 5.72 5.72 0 0
psp22-extension 6.907 6.907 0 0
rand-extension 2.957 2.957 0 0
runtime-call-contract 1.592 1.592 0 0
static-buffer 2.602 2.602 0 0
trait-dyn-cross-contract-calls 2.808 2.808 0 0
trait-dyn-cross-contract-calls/contracts/incrementer 1.571 1.571 0 0
trait-erc20 7.286 7.286 0 0
trait-flipper 1.46 1.46 0 0
trait-incrementer 1.63 1.63 0 0
upgradeable-contracts/delegator 3.869 3.869 0 0
upgradeable-contracts/delegator/delegatee 1.652 1.652 0 0
upgradeable-contracts/delegator/delegatee2 1.652 1.652 0 0
upgradeable-contracts/set-code-hash-migration 1.74 1.74 0 0
upgradeable-contracts/set-code-hash-migration/migration 1.302 1.302 0 0
upgradeable-contracts/set-code-hash-migration/updated-incrementer 1.93 1.93 0 0
upgradeable-contracts/set-code-hash 1.74 1.74 0 0
upgradeable-contracts/set-code-hash/updated-incrementer 1.717 1.717 0 0
wildcard-selector 2.779 2.779 0 0

Link to the run | Last update: Wed Dec 4 12:55:45 CET 2024

cmichi added a commit that referenced this pull request Dec 4, 2024
* Bump version to 5.1.1

* Fix port passing from node process (#2336)

* Have port parsing handle comma-separated list

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to parse valid port from substrate-contracts-node v0.42.0
1 participant